Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mpt): Migrate to thiserror #541

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(mpt): Migrate to thiserror #541

wants to merge 2 commits into from
+325 −188

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Sep 20, 2024

Overview

Migrates kona-mpt to typed errors.

@clabby clabby added K-feature Kind: feature A-mpt Area: `kona-mpt` crate labels Sep 20, 2024
@clabby clabby self-assigned this Sep 20, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 74.52830% with 27 lines in your changes missing coverage. Please review.

Project coverage is 78.1%. Comparing base (72908f9) to head (b22b96b).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/mpt/src/node.rs 58.3% 15 Missing ⚠️
crates/mpt/src/db/mod.rs 81.8% 4 Missing ⚠️
crates/mpt/src/errors.rs 0.0% 3 Missing ⚠️
crates/mpt/src/fetcher.rs 72.7% 3 Missing ⚠️
crates/mpt/src/list_walker.rs 89.4% 2 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced Sep 21, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@clabby clabby

Labels
A-mpt Area: `kona-mpt` crate K-feature Kind: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@clabby